Skip to content

Conversation

Sunjae95
Copy link
Member

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@Sunjae95 Sunjae95 self-assigned this Sep 13, 2024
@github-actions github-actions bot added the js label Sep 13, 2024
@Sunjae95 Sunjae95 requested a review from jaejeong1 September 13, 2024 11:55
@Sunjae95 Sunjae95 marked this pull request as ready for review September 13, 2024 11:55
@Sunjae95 Sunjae95 requested a review from a team as a code owner September 13, 2024 11:55
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 소소한 피드백 드렸지만 승인하는데는 문제되지 않습니다.

Comment on lines +20 to +22
map.forEach((value) => answer.push(value));

return answer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[안 중요] 요렇게 하면 더 깔끔하지 않을까 생각이 들었습니다. 11번째 줄도 필요가 없어지고요.

Suggested change
map.forEach((value) => answer.push(value));
return answer;
return return [...map.values()];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterator는 spread operate가 가능하군요!

@SamTheKorean SamTheKorean merged commit 71bc447 into DaleStudy:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants